pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Close relations opened specifically for AFTER triggers
Date: Wed, 26 Aug 2026 14:42:55 +0000
Message-ID: <E1wzEq6-00000002Cmg-1wRg@gemulon.postgresql.org> (raw)
Close relations opened specifically for AFTER triggers
39dcfda2d fixed an incorrect reuse of ResultRelInfos for AFTER triggers
when the ResultRelInfo needed to have a different ri_RootResultRelInfo.
That caused an issue in logical replication apply workers as
finish_edata() neglects to call ExecCloseResultRelations() and instead
relies on ExecCleanupTupleRouting() to close relations opened during
partitioning's tuple routing. Since 39dcfda2d, because we may have done
some additional table_opens() calls due to having to create an additional
ResultRelInfo because of requirements to have a different
ri_RootResultRelInfo, we should now be explicitly closing any relations
opened on ResultRelInfos in EState's es_trig_target_relations.
Since finish_edate() seems to want to avoid calling
ExecCloseResultRelations(), add a new external function named
ExecCloseTrigTargetRelations().
Reported-by: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Author: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
Discussion: https://postgr.es/m/OS9PR01MB121491E7E05950D108AF9A6D8F5A72@OS9PR01MB12149.jpnprd01.prod.outlook.com
Backpatch-through: 15
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/70d5b066825a8ce5f786313dc9751f3cf1d29569
Modified Files
--------------
src/backend/executor/execMain.c | 16 ++++++++++++++++
src/backend/replication/logical/worker.c | 12 ++++++++----
src/include/executor/executor.h | 1 +
src/test/subscription/t/013_partition.pl | 7 +++++++
4 files changed, 32 insertions(+), 4 deletions(-)
view thread (6+ messages) latest in thread
Message-ID: <E1wzEq6-00000002Cmg-1wRg@gemulon.postgresql.org>
Permalink: ../E1wzEq6-00000002Cmg-1wRg@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wzEq6-00000002Cmg-1wRg@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Close relations opened specifically for AFTER triggers
In-Reply-To: <E1wzEq6-00000002Cmg-1wRg@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox