pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_upgrade: Read nextMultiOffset as a 64-bit value.
Date: Thu, 27 Aug 2026 19:11:20 +0000
Message-ID: <E1wzfVP-00000002NiO-2Zk2@gemulon.postgresql.org> (raw)
pg_upgrade: Read nextMultiOffset as a 64-bit value.
Commit bd8d9c9bdfa widened MultiXactOffset to 64 bits and widened
ControlData.chkpnt_nxtmxoff accordingly, but get_control_data() still
read the "Latest checkpoint's NextMultiOffset" line with str2uint(),
which returns unsigned int.
This commit adds str2uint64(), mirroring the str2uint() helper used
for the other control file fields, and reads the offset with it.
Backpatch to v19, where MultiXactOffset was widened.
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CAD21AoCvzerscfU8o4ARQ793yAGHpQ72r2x5apeC_W2-k=SLCQ@mail.gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e721ce48dc78b58827c35d6a13f9f72a591e68f2
Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 2 +-
src/bin/pg_upgrade/pg_upgrade.h | 1 +
src/bin/pg_upgrade/util.c | 11 +++++++++++
3 files changed, 13 insertions(+), 1 deletion(-)
view thread (2+ messages)
Message-ID: <E1wzfVP-00000002NiO-2Zk2@gemulon.postgresql.org>
Permalink: ../E1wzfVP-00000002NiO-2Zk2@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wzfVP-00000002NiO-2Zk2@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_upgrade: Read nextMultiOffset as a 64-bit value.
In-Reply-To: <E1wzfVP-00000002NiO-2Zk2@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox