agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Wait for checksum state transition in test
Date: Tue, 01 Sep 2026 09:29:50 +0000
Message-ID: <E1x1KoP-000000031AC-3Fg1@gemulon.postgresql.org> (raw)

Wait for checksum state transition in test

The test for disabling data checksums after a failure didn't wait
for the state transition to complete before testing, which could
lead to false negatives in testing.  Fix by passing the wait param
when disabling.  Identified on buildfarm member culicidae.

Author: Daniel Gustafsson <daniel@yesql.se>
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/b2f34fd3-8e98-450e-9e8c-ac08238e9116@gmail.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/135b867a530cac2e3796d87c852b53bef40f0077

Modified Files
--------------
src/test/modules/test_checksums/t/005_injection.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (2+ messages)

Message-ID: <E1x1KoP-000000031AC-3Fg1@gemulon.postgresql.org>
Permalink:  ../E1x1KoP-000000031AC-3Fg1@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1x1KoP-000000031AC-3Fg1@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Wait for checksum state transition in test
  In-Reply-To: <E1x1KoP-000000031AC-3Fg1@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox