agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_dump: Fix performance regression in attribute statistics quer
Date: Tue, 01 Sep 2026 21:28:18 +0000
Message-ID: <E1x1W1h-000000035YR-3KDG@gemulon.postgresql.org> (raw)
pg_dump: Fix performance regression in attribute statistics query.
After adding pg_stats.tableid, we taught pg_dump to use it in the
attribute statistics query for servers running v19 or later.
Notably, we did not give this new form of the query a "redundant
filter clause" like we did the pre-v19 form. Testing indicates
that produces a significant performance regression, and that adding
a similar filter clause to the v19-or-later form of the query fixes
it.
Oversight in commit 4b5ba0c4ca.
Reviewed-by: Sami Imseih <samimseih@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/apQ9nvLW_zFdarYd%40nathan
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7da24355a2993721bf9bc54224b3bb3e601530ce
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
view thread (2+ messages)
Message-ID: <E1x1W1h-000000035YR-3KDG@gemulon.postgresql.org>
Permalink: ../E1x1W1h-000000035YR-3KDG@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x1W1h-000000035YR-3KDG@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_dump: Fix performance regression in attribute statistics quer
In-Reply-To: <E1x1W1h-000000035YR-3KDG@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox