agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Speed up pg_waldump TAP test 4+ messages / 1 participants [nested] [flat]
* pgsql: Speed up pg_waldump TAP test @ 2026-09-02 00:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-09-02 00:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Speed up pg_waldump TAP test Several invocations decoded and printed the full WAL range even though the test only needs to confirm that a command form works or that decoding reaches a specific error. Limit those checks to one record, and start the fall-off-the-end checks near the end of the generated WAL. This change reduces the IPC overhead overall, particularly on Windows, without reducing coverage. I am usually hesitant to backpatch such changes as this is only an improvement, but the gains are too good in terms of IO and runtime, for both the CI and the buildfarm. Based on the numbers provided, the CI takes 30% less time to run the test with this change on Windows (worst case shown on the lists). These tests have been introduced in 96063e28366b. Author: Sehrope Sarkuni <sehrope@jackdb.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAH7T-araSEdsNpxiKaMOW8kr_ZHhekCLHx5yzm2ksq4FdgULbA@mail.gmail.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/a9eebaf3735b8663ec8d638c9d81c54730ddd9de Modified Files -------------- src/bin/pg_waldump/t/001_basic.pl | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Speed up pg_waldump TAP test @ 2026-09-02 00:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-09-02 00:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Speed up pg_waldump TAP test Several invocations decoded and printed the full WAL range even though the test only needs to confirm that a command form works or that decoding reaches a specific error. Limit those checks to one record, and start the fall-off-the-end checks near the end of the generated WAL. This change reduces the IPC overhead overall, particularly on Windows, without reducing coverage. I am usually hesitant to backpatch such changes as this is only an improvement, but the gains are too good in terms of IO and runtime, for both the CI and the buildfarm. Based on the numbers provided, the CI takes 30% less time to run the test with this change on Windows (worst case shown on the lists). These tests have been introduced in 96063e28366b. Author: Sehrope Sarkuni <sehrope@jackdb.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAH7T-araSEdsNpxiKaMOW8kr_ZHhekCLHx5yzm2ksq4FdgULbA@mail.gmail.com Backpatch-through: 17 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8e6860fb9638b5db784a24419d4441f0bf2cd04c Modified Files -------------- src/bin/pg_waldump/t/001_basic.pl | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Speed up pg_waldump TAP test @ 2026-09-02 00:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-09-02 00:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Speed up pg_waldump TAP test Several invocations decoded and printed the full WAL range even though the test only needs to confirm that a command form works or that decoding reaches a specific error. Limit those checks to one record, and start the fall-off-the-end checks near the end of the generated WAL. This change reduces the IPC overhead overall, particularly on Windows, without reducing coverage. I am usually hesitant to backpatch such changes as this is only an improvement, but the gains are too good in terms of IO and runtime, for both the CI and the buildfarm. Based on the numbers provided, the CI takes 30% less time to run the test with this change on Windows (worst case shown on the lists). These tests have been introduced in 96063e28366b. Author: Sehrope Sarkuni <sehrope@jackdb.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAH7T-araSEdsNpxiKaMOW8kr_ZHhekCLHx5yzm2ksq4FdgULbA@mail.gmail.com Backpatch-through: 17 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e075a10719c1a426d4602ffd4c52d5ee79b084b1 Modified Files -------------- src/bin/pg_waldump/t/001_basic.pl | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Speed up pg_waldump TAP test @ 2026-09-02 00:20 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-09-02 00:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Speed up pg_waldump TAP test Several invocations decoded and printed the full WAL range even though the test only needs to confirm that a command form works or that decoding reaches a specific error. Limit those checks to one record, and start the fall-off-the-end checks near the end of the generated WAL. This change reduces the IPC overhead overall, particularly on Windows, without reducing coverage. I am usually hesitant to backpatch such changes as this is only an improvement, but the gains are too good in terms of IO and runtime, for both the CI and the buildfarm. Based on the numbers provided, the CI takes 30% less time to run the test with this change on Windows (worst case shown on the lists). These tests have been introduced in 96063e28366b. Author: Sehrope Sarkuni <sehrope@jackdb.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAH7T-araSEdsNpxiKaMOW8kr_ZHhekCLHx5yzm2ksq4FdgULbA@mail.gmail.com Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/680f707fb2e4e3a954137e027e89afbf2d6f7944 Modified Files -------------- src/bin/pg_waldump/t/001_basic.pl | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-09-02 00:20 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-02 00:20 pgsql: Speed up pg_waldump TAP test Michael Paquier <michael@paquier.xyz> 2026-09-02 00:20 pgsql: Speed up pg_waldump TAP test Michael Paquier <michael@paquier.xyz> 2026-09-02 00:20 pgsql: Speed up pg_waldump TAP test Michael Paquier <michael@paquier.xyz> 2026-09-02 00:20 pgsql: Speed up pg_waldump TAP test Michael Paquier <michael@paquier.xyz>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox