agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Speed up pg_waldump TAP test
Date: Wed, 02 Sep 2026 00:20:03 +0000
Message-ID: <E1x1Yhu-000000036T0-3Hzp@gemulon.postgresql.org> (raw)
Speed up pg_waldump TAP test
Several invocations decoded and printed the full WAL range even though
the test only needs to confirm that a command form works or that
decoding reaches a specific error. Limit those checks to one record,
and start the fall-off-the-end checks near the end of the generated WAL.
This change reduces the IPC overhead overall, particularly on Windows,
without reducing coverage.
I am usually hesitant to backpatch such changes as this is only an
improvement, but the gains are too good in terms of IO and runtime, for
both the CI and the buildfarm. Based on the numbers provided, the CI
takes 30% less time to run the test with this change on Windows (worst
case shown on the lists). These tests have been introduced in
96063e28366b.
Author: Sehrope Sarkuni <sehrope@jackdb.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Discussion: https://postgr.es/m/CAH7T-araSEdsNpxiKaMOW8kr_ZHhekCLHx5yzm2ksq4FdgULbA@mail.gmail.com
Backpatch-through: 17
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e075a10719c1a426d4602ffd4c52d5ee79b084b1
Modified Files
--------------
src/bin/pg_waldump/t/001_basic.pl | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
view thread (4+ messages) latest in thread
Message-ID: <E1x1Yhu-000000036T0-3Hzp@gemulon.postgresql.org>
Permalink: ../E1x1Yhu-000000036T0-3Hzp@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x1Yhu-000000036T0-3Hzp@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Speed up pg_waldump TAP test
In-Reply-To: <E1x1Yhu-000000036T0-3Hzp@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox