agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add more test coverage for pg_clear_attribute_stats()
Date: Wed, 02 Sep 2026 07:23:10 +0000
Message-ID: <E1x1fJN-000000039Cs-1Xk2@gemulon.postgresql.org> (raw)
Add more test coverage for pg_clear_attribute_stats()
pg_clear_attribute_stats() was called exactly once in the whole test
suite, only for a correct cleanup. None of its failure scenarios were
covered, in terms of:
- NULL input values
- Incorrect object names (schema, attribute, relation)
- Incorrect relkinds
- Inherited pg_statistic entry cleanup
All these cases are now covered. This would have caught the failure
fixed by 11ed011ae22, as one example.
Author: Zhong ShiHao <zhong950419@gmail.com>
Discussion: https://postgr.es/m/CAGRkXqQEFzVh_bQSoLGDqaRTq7Xta6OUoda8PDrWDPWcAuwk=w@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/66f85615d5d650c47b6e8ea75e32a6817cb23dac
Modified Files
--------------
src/test/regress/expected/stats_import.out | 137 +++++++++++++++++++++++++++++
src/test/regress/sql/stats_import.sql | 96 ++++++++++++++++++++
2 files changed, 233 insertions(+)
Message-ID: <E1x1fJN-000000039Cs-1Xk2@gemulon.postgresql.org>
Permalink: ../E1x1fJN-000000039Cs-1Xk2@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x1fJN-000000039Cs-1Xk2@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add more test coverage for pg_clear_attribute_stats()
In-Reply-To: <E1x1fJN-000000039Cs-1Xk2@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox