agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: initdb: Pad rewritten GUC lines with spaces instead of tabs.
Date: Wed, 02 Sep 2026 14:23:52 +0000
Message-ID: <E1x1lsV-00000003Bkw-3hyp@gemulon.postgresql.org> (raw)

initdb: Pad rewritten GUC lines with spaces instead of tabs.

Commit f63ae72bbc converted postgresql.conf.sample to spaces so
that it lines up at any tab width, but replace_guc_value() still
pads with tabs when it re-aligns the trailing comment of a
rewritten setting.  Fix that.

Oversight in commit f63ae72bbc.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/apRezMywHRuR5h-6%40nathan
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c0584c27f4f70935b3ccf31e58edb8e175fec447

Modified Files
--------------
src/bin/initdb/initdb.c | 31 +++++--------------------------
1 file changed, 5 insertions(+), 26 deletions(-)



view thread (2+ messages)

Message-ID: <E1x1lsV-00000003Bkw-3hyp@gemulon.postgresql.org>
Permalink:  ../E1x1lsV-00000003Bkw-3hyp@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1x1lsV-00000003Bkw-3hyp@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: initdb: Pad rewritten GUC lines with spaces instead of tabs.
  In-Reply-To: <E1x1lsV-00000003Bkw-3hyp@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox