agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stabilize xid_wraparound/t/002_limits.pl test.
Date: Wed, 02 Sep 2026 14:53:42 +0000
Message-ID: <E1x1mLN-00000003BwP-0el6@gemulon.postgresql.org> (raw)
Stabilize xid_wraparound/t/002_limits.pl test.
Not many buildfarm members run this test, since it's gated behind
PG_TEST_EXTRA=xid_wraparound, but of those that do, the slower ones
not infrequently fail. The reason seems to be that the test expects
an INSERT command to either succeed or fail, but there's a window
where it can succeed while issuing a warning about impending
wraparound. poll_query_until treats nonempty stderr as a failure,
so it loops an extra time until the INSERT succeeds with no warning.
There seems no reason to treat this behavior as wrong, so adjust
the test to accept it.
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Diagnosed-by: Alexander Lakhin <exclusion@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/7a68bee2-91bd-481d-be44-160e6beebc83@gmail.com
Backpatch-through: 17
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e073b64d33215d4bfded1366549b96580a402c06
Modified Files
--------------
src/test/modules/xid_wraparound/t/002_limits.pl | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
view thread (4+ messages) latest in thread
Message-ID: <E1x1mLN-00000003BwP-0el6@gemulon.postgresql.org>
Permalink: ../E1x1mLN-00000003BwP-0el6@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x1mLN-00000003BwP-0el6@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Stabilize xid_wraparound/t/002_limits.pl test.
In-Reply-To: <E1x1mLN-00000003BwP-0el6@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox