agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Stabilize xid_wraparound/t/002_limits.pl test. 4+ messages / 1 participants [nested] [flat]
* pgsql: Stabilize xid_wraparound/t/002_limits.pl test. @ 2026-09-02 14:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2026-09-02 14:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize xid_wraparound/t/002_limits.pl test. Not many buildfarm members run this test, since it's gated behind PG_TEST_EXTRA=xid_wraparound, but of those that do, the slower ones not infrequently fail. The reason seems to be that the test expects an INSERT command to either succeed or fail, but there's a window where it can succeed while issuing a warning about impending wraparound. poll_query_until treats nonempty stderr as a failure, so it loops an extra time until the INSERT succeeds with no warning. There seems no reason to treat this behavior as wrong, so adjust the test to accept it. Reported-by: Alexander Lakhin <exclusion@gmail.com> Diagnosed-by: Alexander Lakhin <exclusion@gmail.com> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/7a68bee2-91bd-481d-be44-160e6beebc83@gmail.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e073b64d33215d4bfded1366549b96580a402c06 Modified Files -------------- src/test/modules/xid_wraparound/t/002_limits.pl | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Stabilize xid_wraparound/t/002_limits.pl test. @ 2026-09-02 14:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2026-09-02 14:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize xid_wraparound/t/002_limits.pl test. Not many buildfarm members run this test, since it's gated behind PG_TEST_EXTRA=xid_wraparound, but of those that do, the slower ones not infrequently fail. The reason seems to be that the test expects an INSERT command to either succeed or fail, but there's a window where it can succeed while issuing a warning about impending wraparound. poll_query_until treats nonempty stderr as a failure, so it loops an extra time until the INSERT succeeds with no warning. There seems no reason to treat this behavior as wrong, so adjust the test to accept it. Reported-by: Alexander Lakhin <exclusion@gmail.com> Diagnosed-by: Alexander Lakhin <exclusion@gmail.com> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/7a68bee2-91bd-481d-be44-160e6beebc83@gmail.com Backpatch-through: 17 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/75716fe3ddbd98737459f1d24c7f459a7173ff27 Modified Files -------------- src/test/modules/xid_wraparound/t/002_limits.pl | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Stabilize xid_wraparound/t/002_limits.pl test. @ 2026-09-02 14:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2026-09-02 14:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize xid_wraparound/t/002_limits.pl test. Not many buildfarm members run this test, since it's gated behind PG_TEST_EXTRA=xid_wraparound, but of those that do, the slower ones not infrequently fail. The reason seems to be that the test expects an INSERT command to either succeed or fail, but there's a window where it can succeed while issuing a warning about impending wraparound. poll_query_until treats nonempty stderr as a failure, so it loops an extra time until the INSERT succeeds with no warning. There seems no reason to treat this behavior as wrong, so adjust the test to accept it. Reported-by: Alexander Lakhin <exclusion@gmail.com> Diagnosed-by: Alexander Lakhin <exclusion@gmail.com> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/7a68bee2-91bd-481d-be44-160e6beebc83@gmail.com Backpatch-through: 17 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b51dd2b2c5a390dca8868675d7f01d8d3874cd7b Modified Files -------------- src/test/modules/xid_wraparound/t/002_limits.pl | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Stabilize xid_wraparound/t/002_limits.pl test. @ 2026-09-02 14:53 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 4+ messages in thread From: Tom Lane @ 2026-09-02 14:53 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Stabilize xid_wraparound/t/002_limits.pl test. Not many buildfarm members run this test, since it's gated behind PG_TEST_EXTRA=xid_wraparound, but of those that do, the slower ones not infrequently fail. The reason seems to be that the test expects an INSERT command to either succeed or fail, but there's a window where it can succeed while issuing a warning about impending wraparound. poll_query_until treats nonempty stderr as a failure, so it loops an extra time until the INSERT succeeds with no warning. There seems no reason to treat this behavior as wrong, so adjust the test to accept it. Reported-by: Alexander Lakhin <exclusion@gmail.com> Diagnosed-by: Alexander Lakhin <exclusion@gmail.com> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/7a68bee2-91bd-481d-be44-160e6beebc83@gmail.com Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/61636c17b391bb5b93dbeeed24553198187752fc Modified Files -------------- src/test/modules/xid_wraparound/t/002_limits.pl | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-09-02 14:53 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-02 14:53 pgsql: Stabilize xid_wraparound/t/002_limits.pl test. Tom Lane <tgl@sss.pgh.pa.us> 2026-09-02 14:53 pgsql: Stabilize xid_wraparound/t/002_limits.pl test. Tom Lane <tgl@sss.pgh.pa.us> 2026-09-02 14:53 pgsql: Stabilize xid_wraparound/t/002_limits.pl test. Tom Lane <tgl@sss.pgh.pa.us> 2026-09-02 14:53 pgsql: Stabilize xid_wraparound/t/002_limits.pl test. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox