agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_upgrade: Skip tests for live server checks on Windows
Date: Fri, 04 Sep 2026 07:03:51 +0000
Message-ID: <E1x2Nxm-00000003PqY-0c9s@gemulon.postgresql.org> (raw)
pg_upgrade: Skip tests for live server checks on Windows
The tests added by 88aa6ca138a1 could fail on Windows, due to the fact
that pg_ctl is not able to compare the PID stored in postmaster.pid with
the postmaster that has been spawned. The postmaster may not be seen as
running, and could fail the live check.
Note that pg_ctl falls back on checking the start time recorded in
postmaster.pid, with a lag of 2 seconds. So, outside the possibility of
fixing pg_ctl so as the PID file checks become more reliable, an
alternative solution would be to use the same trick as the pg_ctl test
001_start_stop.pl, with a hardcoded sleep of *3* seconds, at least. I
cannot get excited about spreading this pattern, though, so skip it is
as we do not lose any coverage.
Per report from buildfarm members fairywren.
Discussion: https://postgr.es/m/apphYnTYS1WtLkKU@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ac1ccbea98f166548890f14c9ca9d4ab055ca291
Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 73 +++++++++++++++++++---------------
1 file changed, 40 insertions(+), 33 deletions(-)
Message-ID: <E1x2Nxm-00000003PqY-0c9s@gemulon.postgresql.org>
Permalink: ../E1x2Nxm-00000003PqY-0c9s@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x2Nxm-00000003PqY-0c9s@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_upgrade: Skip tests for live server checks on Windows
In-Reply-To: <E1x2Nxm-00000003PqY-0c9s@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox