agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: Fix buildfarm failure introduced by commit e65dbc9927.
3+ messages / 1 participants
[nested] [flat]

* pgsql: Fix buildfarm failure introduced by commit e65dbc9927.
@ 2025-01-23 12:31  Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Amit Kapila @ 2025-01-23 12:31 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix buildfarm failure introduced by commit e65dbc9927.

The patch had incorrectly specified the default value for
publish_generated_columns during the query formation in pg_dump.

Author: Vignesh C <vignesh21@gmail.com>
Discussion: https://postgr.es/m/CAA4eK1KfZYTD8Hpi9TD1KaB8rNUBR9baUvTxa5wYyZDGbEaa6g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b35434b134b1e1a306649a8c63c5c46afdcf7b1e

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix buildfarm failure introduced by 6168c65ddc.
@ 2026-09-08 05:22  Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Amit Kapila @ 2026-09-08 05:22 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix buildfarm failure introduced by 6168c65ddc.

Commit 6168c65ddc added a test verifying that the conflict detection
slot's xmin regresses to the horizon pinned by an in-progress transaction
in the database of a newly added subscription that has retain_dead_tuples
enabled. However, it used query_until(), which can return before starting
a transaction, allowing the test to proceed without a pinned xid.

Use query_safe() so the transaction setup completes synchronously and the
xid is assigned before the xmin checks run.

Per buildfarm.

Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Discussion: https://postgr.es/m/OS9PR01MB12149257A97EE1BD3296F6AEBF5B12@OS9PR01MB12149.jpnprd01.prod.outlook.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b3dfd8d4ea1547ccbb6fca64f0334e40762b0f4d

Modified Files
--------------
src/test/subscription/t/035_conflicts.pl | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Fix buildfarm failure introduced by 6168c65ddc.
@ 2026-09-08 05:22  Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Amit Kapila @ 2026-09-08 05:22 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix buildfarm failure introduced by 6168c65ddc.

Commit 6168c65ddc added a test verifying that the conflict detection
slot's xmin regresses to the horizon pinned by an in-progress transaction
in the database of a newly added subscription that has retain_dead_tuples
enabled. However, it used query_until(), which can return before starting
a transaction, allowing the test to proceed without a pinned xid.

Use query_safe() so the transaction setup completes synchronously and the
xid is assigned before the xmin checks run.

Per buildfarm.

Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Discussion: https://postgr.es/m/OS9PR01MB12149257A97EE1BD3296F6AEBF5B12@OS9PR01MB12149.jpnprd01.prod.outlook.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d2384bc30f6882d30cb49e2912580ab95d642f3c

Modified Files
--------------
src/test/subscription/t/035_conflicts.pl | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2026-09-08 05:22 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-01-23 12:31 pgsql: Fix buildfarm failure introduced by commit e65dbc9927. Amit Kapila <akapila@postgresql.org>
2026-09-08 05:22 pgsql: Fix buildfarm failure introduced by 6168c65ddc. Amit Kapila <akapila@postgresql.org>
2026-09-08 05:22 pgsql: Fix buildfarm failure introduced by 6168c65ddc. Amit Kapila <akapila@postgresql.org>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox