agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix buildfarm failure introduced by 6168c65ddc.
Date: Tue, 08 Sep 2026 05:22:48 +0000
Message-ID: <E1x3oIB-00000003wVh-1Wr4@gemulon.postgresql.org> (raw)
Fix buildfarm failure introduced by 6168c65ddc.
Commit 6168c65ddc added a test verifying that the conflict detection
slot's xmin regresses to the horizon pinned by an in-progress transaction
in the database of a newly added subscription that has retain_dead_tuples
enabled. However, it used query_until(), which can return before starting
a transaction, allowing the test to proceed without a pinned xid.
Use query_safe() so the transaction setup completes synchronously and the
xid is assigned before the xmin checks run.
Per buildfarm.
Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Discussion: https://postgr.es/m/OS9PR01MB12149257A97EE1BD3296F6AEBF5B12@OS9PR01MB12149.jpnprd01.prod.outlook.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d2384bc30f6882d30cb49e2912580ab95d642f3c
Modified Files
--------------
src/test/subscription/t/035_conflicts.pl | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
view thread (3+ messages)
Message-ID: <E1x3oIB-00000003wVh-1Wr4@gemulon.postgresql.org>
Permalink: ../E1x3oIB-00000003wVh-1Wr4@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x3oIB-00000003wVh-1Wr4@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix buildfarm failure introduced by 6168c65ddc.
In-Reply-To: <E1x3oIB-00000003wVh-1Wr4@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox