agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Stabilize 026_overwrite_contrecord test
Date: Tue, 08 Sep 2026 07:51:16 +0000
Message-ID: <E1x3qbr-00000003xaO-3FaO@gemulon.postgresql.org> (raw)
Stabilize 026_overwrite_contrecord test
On slow machines, this test can take long enough to generate WAL that a
time-based checkpoint occurs before the primary is stopped. If the
checkpoint record is written to the tail WAL segment that the test later
removes, a standby initialized from the resulting backup tries to read
the missing checkpoint record and fails with a PANIC during startup.
This caused the test to fail on buildfarm member skink.
Fix this by setting checkpoint_timeout high enough to prevent unrelated
checkpoints during the test. This follows the approach used by other
recovery tests, such as 043_no_contrecord_switch.pl, that depend on a
specific WAL layout.
Backpatch to all supported versions.
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Author: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwFajfjKhvNSTkTcE-wFn30p_A0_i1cvk-Q=FJhDr_5cXA@mail.gmail.com
Discussion: https://postgr.es/m/9ffdb19a-7a89-424e-925a-dd981c37f0ba@gmail.com
Backpatch-through: 14
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/abea7cc0436691177465bb23b44e2daf0c68c5be
Modified Files
--------------
src/test/recovery/t/026_overwrite_contrecord.pl | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
view thread (7+ messages)
Message-ID: <E1x3qbr-00000003xaO-3FaO@gemulon.postgresql.org>
Permalink: ../E1x3qbr-00000003xaO-3FaO@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x3qbr-00000003xaO-3FaO@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Stabilize 026_overwrite_contrecord test
In-Reply-To: <E1x3qbr-00000003xaO-3FaO@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox