agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Resolve untyped parameters in FOR PORTION OF FROM/TO bounds
Date: Tue, 08 Sep 2026 08:00:08 +0000
Message-ID: <E1x3qkR-00000003xkL-1U2B@gemulon.postgresql.org> (raw)
Resolve untyped parameters in FOR PORTION OF FROM/TO bounds
FOR PORTION OF valid_at FROM $1 TO $2 fails with "could not determine data
type of parameter $1", so using PREPARE requires users to say $1::date
etc. But transformForPortionOfClause() already coerces the bounds, since
it builds a constructor for the targeted range. We just need to store the
coerced expressions in targetFrom and targetTo.
This also improves pg_get_ruledef(), which now renders an untyped NULL
bound as NULL::date instead of NULL::unknown.
Reported-by: Noah Misch <noah@leadboat.com>
Author: Paul A. Jungwirth <pj@illuminatedcomputing.com>
Discussion: https://www.postgresql.org/message-id/flat/CA%2BrenyW1uJp1dw%3DiK7MsWfbbZf-dKP_4JLoQ65wj%3Dfry35FjCw...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/438f027238c0582e89d4c81e3f88d9b1d6d810d0
Modified Files
--------------
src/backend/parser/analyze.c | 12 ++-
src/test/regress/expected/for_portion_of.out | 106 ++++++++++++++++++++++++++-
src/test/regress/sql/for_portion_of.sql | 71 ++++++++++++++++++
3 files changed, 185 insertions(+), 4 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1x3qkR-00000003xkL-1U2B@gemulon.postgresql.org>
Permalink: ../E1x3qkR-00000003xkL-1U2B@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x3qkR-00000003xkL-1U2B@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Resolve untyped parameters in FOR PORTION OF FROM/TO bounds
In-Reply-To: <E1x3qkR-00000003xkL-1U2B@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox