agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" 7+ messages / 1 participants [nested] [flat]
* pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" @ 2026-09-08 11:09 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Alexander Korotkov @ 2026-09-08 11:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Mark modified the FSM buffer as dirty during recovery" This reverts commit c06d1a4ba6b26eef27b04074683cccade6c277ee. The commit assumed that if the FSM code tolerates torn pages, everything else does so. Readers that do not tolerate that include RelationCopyStorage(), used by ALTER TABLE ... SET TABLESPACE for every fork, the read stream in RelationCopyStorageUsingBuffer() used by CREATE DATABASE ... STRATEGY = wal_log, and, most awkwardly, the checksum verification in base backups and pg_checksums. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20260901211837.f6.noahmisch%40microsoft.com Backpatch-through: 14 Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/35e4b760a5e91808f315184d020e58ac2695619c Modified Files -------------- src/backend/storage/freespace/freespace.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" @ 2026-09-08 11:09 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Alexander Korotkov @ 2026-09-08 11:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Mark modified the FSM buffer as dirty during recovery" This reverts commit c06d1a4ba6b26eef27b04074683cccade6c277ee. The commit assumed that if the FSM code tolerates torn pages, everything else does so. Readers that do not tolerate that include RelationCopyStorage(), used by ALTER TABLE ... SET TABLESPACE for every fork, the read stream in RelationCopyStorageUsingBuffer() used by CREATE DATABASE ... STRATEGY = wal_log, and, most awkwardly, the checksum verification in base backups and pg_checksums. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20260901211837.f6.noahmisch%40microsoft.com Backpatch-through: 14 Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/89834e3f2e05a4f2da59a5ca60821c4b3e26e2e4 Modified Files -------------- src/backend/storage/freespace/freespace.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" @ 2026-09-08 11:09 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Alexander Korotkov @ 2026-09-08 11:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Mark modified the FSM buffer as dirty during recovery" This reverts commit c06d1a4ba6b26eef27b04074683cccade6c277ee. The commit assumed that if the FSM code tolerates torn pages, everything else does so. Readers that do not tolerate that include RelationCopyStorage(), used by ALTER TABLE ... SET TABLESPACE for every fork, the read stream in RelationCopyStorageUsingBuffer() used by CREATE DATABASE ... STRATEGY = wal_log, and, most awkwardly, the checksum verification in base backups and pg_checksums. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20260901211837.f6.noahmisch%40microsoft.com Backpatch-through: 14 Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a8004e161ba5c5f4eb43058b0c8c298dbc7119f4 Modified Files -------------- src/backend/storage/freespace/freespace.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" @ 2026-09-08 11:09 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Alexander Korotkov @ 2026-09-08 11:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Mark modified the FSM buffer as dirty during recovery" This reverts commit c06d1a4ba6b26eef27b04074683cccade6c277ee. The commit assumed that if the FSM code tolerates torn pages, everything else does so. Readers that do not tolerate that include RelationCopyStorage(), used by ALTER TABLE ... SET TABLESPACE for every fork, the read stream in RelationCopyStorageUsingBuffer() used by CREATE DATABASE ... STRATEGY = wal_log, and, most awkwardly, the checksum verification in base backups and pg_checksums. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20260901211837.f6.noahmisch%40microsoft.com Backpatch-through: 14 Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bee33974ee726785a674fafd1c58f8d0cd9c6667 Modified Files -------------- src/backend/storage/freespace/freespace.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" @ 2026-09-08 11:09 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Alexander Korotkov @ 2026-09-08 11:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Mark modified the FSM buffer as dirty during recovery" This reverts commit c06d1a4ba6b26eef27b04074683cccade6c277ee. The commit assumed that if the FSM code tolerates torn pages, everything else does so. Readers that do not tolerate that include RelationCopyStorage(), used by ALTER TABLE ... SET TABLESPACE for every fork, the read stream in RelationCopyStorageUsingBuffer() used by CREATE DATABASE ... STRATEGY = wal_log, and, most awkwardly, the checksum verification in base backups and pg_checksums. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20260901211837.f6.noahmisch%40microsoft.com Backpatch-through: 14 Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5d63dbd9774dcb28d7c88bfce42505376b201861 Modified Files -------------- src/backend/storage/freespace/freespace.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" @ 2026-09-08 11:09 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Alexander Korotkov @ 2026-09-08 11:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Mark modified the FSM buffer as dirty during recovery" This reverts commit c06d1a4ba6b26eef27b04074683cccade6c277ee. The commit assumed that if the FSM code tolerates torn pages, everything else does so. Readers that do not tolerate that include RelationCopyStorage(), used by ALTER TABLE ... SET TABLESPACE for every fork, the read stream in RelationCopyStorageUsingBuffer() used by CREATE DATABASE ... STRATEGY = wal_log, and, most awkwardly, the checksum verification in base backups and pg_checksums. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20260901211837.f6.noahmisch%40microsoft.com Backpatch-through: 14 Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d0518cb3e40503859e5dd17a0a75de9b8967fe4b Modified Files -------------- src/backend/storage/freespace/freespace.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" @ 2026-09-08 11:09 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Alexander Korotkov @ 2026-09-08 11:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Mark modified the FSM buffer as dirty during recovery" This reverts commit c06d1a4ba6b26eef27b04074683cccade6c277ee. The commit assumed that if the FSM code tolerates torn pages, everything else does so. Readers that do not tolerate that include RelationCopyStorage(), used by ALTER TABLE ... SET TABLESPACE for every fork, the read stream in RelationCopyStorageUsingBuffer() used by CREATE DATABASE ... STRATEGY = wal_log, and, most awkwardly, the checksum verification in base backups and pg_checksums. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20260901211837.f6.noahmisch%40microsoft.com Backpatch-through: 14 Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3bed1f91aa5f184202ffb24f5af359f5af2cd1cd Modified Files -------------- src/backend/storage/freespace/freespace.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2026-09-08 11:09 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-08 11:09 pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" Alexander Korotkov <akorotkov@postgresql.org> 2026-09-08 11:09 pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" Alexander Korotkov <akorotkov@postgresql.org> 2026-09-08 11:09 pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" Alexander Korotkov <akorotkov@postgresql.org> 2026-09-08 11:09 pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" Alexander Korotkov <akorotkov@postgresql.org> 2026-09-08 11:09 pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" Alexander Korotkov <akorotkov@postgresql.org> 2026-09-08 11:09 pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" Alexander Korotkov <akorotkov@postgresql.org> 2026-09-08 11:09 pgsql: Revert "Mark modified the FSM buffer as dirty during recovery" Alexander Korotkov <akorotkov@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox