agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Mark modified the FSM buffer as dirty during recovery"
Date: Tue, 08 Sep 2026 11:09:13 +0000
Message-ID: <E1x3thQ-00000003yy7-2q9E@gemulon.postgresql.org> (raw)
Revert "Mark modified the FSM buffer as dirty during recovery"
This reverts commit c06d1a4ba6b26eef27b04074683cccade6c277ee.
The commit assumed that if the FSM code tolerates torn pages, everything else
does so. Readers that do not tolerate that include RelationCopyStorage(),
used by ALTER TABLE ... SET TABLESPACE for every fork, the read stream in
RelationCopyStorageUsingBuffer() used by CREATE DATABASE ... STRATEGY =
wal_log, and, most awkwardly, the checksum verification in base backups and
pg_checksums.
Reported-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20260901211837.f6.noahmisch%40microsoft.com
Backpatch-through: 14
Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d0518cb3e40503859e5dd17a0a75de9b8967fe4b
Modified Files
--------------
src/backend/storage/freespace/freespace.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
view thread (7+ messages) latest in thread
Message-ID: <E1x3thQ-00000003yy7-2q9E@gemulon.postgresql.org>
Permalink: ../E1x3thQ-00000003yy7-2q9E@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x3thQ-00000003yy7-2q9E@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revert "Mark modified the FSM buffer as dirty during recovery"
In-Reply-To: <E1x3thQ-00000003yy7-2q9E@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox