agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_stash_advice: Fix failure to reload empty advice string.
Date: Tue, 08 Sep 2026 15:08:21 +0000
Message-ID: <E1x3xQq-000000040WL-1sqH@gemulon.postgresql.org> (raw)
pg_stash_advice: Fix failure to reload empty advice string.
There's not really any good reason to store an empty advice string
in an advice stash, but it's entirely possible that some people might
do it by accident. If they do that without this fix, restarting the
system will result in failure while reloading pg_stash_advice.tsv.
The root cause is that I (rhaas) did not think clearly enough when
defining pgsa_next_tsv_field(). After returning each field on the
line, it set *cursor to the start of the next field, and after
returning all of them, it set *cursor to the trailing NUL byte. But
when the last field on the line is empty, this is ambiguous: if we're
pointing at the trailing NUL byte, it could be either because it's the
start of the zero-length field or because we're out of fields. To
remove the ambiguity, this commit decides that *cursor will instead
be set to NULL when there are no more fields.
Reported-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20260827171830.68.noahmisch@microsoft.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/dc33cca1859e2d2500ee8f3c0e564561428b4fcf
Modified Files
--------------
contrib/pg_stash_advice/stashpersist.c | 33 ++++++++++++++++++++------------
contrib/pg_stash_advice/t/001_persist.pl | 18 +++++++++--------
2 files changed, 31 insertions(+), 20 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1x3xQq-000000040WL-1sqH@gemulon.postgresql.org>
Permalink: ../E1x3xQq-000000040WL-1sqH@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x3xQq-000000040WL-1sqH@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_stash_advice: Fix failure to reload empty advice string.
In-Reply-To: <E1x3xQq-000000040WL-1sqH@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox