agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Remove stale XXX comment in logical launcher 2+ messages / 1 participants [nested] [flat]
* pgsql: Remove stale XXX comment in logical launcher @ 2026-09-09 09:11 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2026-09-09 09:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove stale XXX comment in logical launcher An XXX comment in launcher.c added by commit 2af1dc89282b questioned why the slot drop does not request disabling logical decoding. But the conflict detection slot is a physical slot, so there is no logical decoding state to disable. Remove that comment and clarify the situation elsewhere. Author: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 19 Discussion: https://postgr.es/m/TY4PR01MB177186C8AB596F30DF704ECDC94B62@TY4PR01MB17718.jpnprd01.prod.outlook.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7beefa8d46978341aed7ba14cc82bf37c0564948 Modified Files -------------- src/backend/replication/logical/launcher.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Remove stale XXX comment in logical launcher @ 2026-09-09 09:11 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2026-09-09 09:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove stale XXX comment in logical launcher An XXX comment in launcher.c added by commit 2af1dc89282b questioned why the slot drop does not request disabling logical decoding. But the conflict detection slot is a physical slot, so there is no logical decoding state to disable. Remove that comment and clarify the situation elsewhere. Author: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 19 Discussion: https://postgr.es/m/TY4PR01MB177186C8AB596F30DF704ECDC94B62@TY4PR01MB17718.jpnprd01.prod.outlook.com Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/46c6fb9a82f2eaa0b56f1231e12e65af39e5ec84 Modified Files -------------- src/backend/replication/logical/launcher.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-09 09:11 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-09 09:11 pgsql: Remove stale XXX comment in logical launcher Álvaro Herrera <alvherre@kurilemu.de> 2026-09-09 09:11 pgsql: Remove stale XXX comment in logical launcher Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox