agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove stale XXX comment in logical launcher
Date: Wed, 09 Sep 2026 09:11:21 +0000
Message-ID: <E1x4EKu-000000046w9-1tsx@gemulon.postgresql.org> (raw)
Remove stale XXX comment in logical launcher
An XXX comment in launcher.c added by commit 2af1dc89282b questioned why
the slot drop does not request disabling logical decoding. But the
conflict detection slot is a physical slot, so there is no logical
decoding state to disable. Remove that comment and clarify the
situation elsewhere.
Author: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Reviewed-by: shveta malik <shveta.malik@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/TY4PR01MB177186C8AB596F30DF704ECDC94B62@TY4PR01MB17718.jpnprd01.prod.outlook.com
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/46c6fb9a82f2eaa0b56f1231e12e65af39e5ec84
Modified Files
--------------
src/backend/replication/logical/launcher.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
view thread (2+ messages)
Message-ID: <E1x4EKu-000000046w9-1tsx@gemulon.postgresql.org>
Permalink: ../E1x4EKu-000000046w9-1tsx@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4EKu-000000046w9-1tsx@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove stale XXX comment in logical launcher
In-Reply-To: <E1x4EKu-000000046w9-1tsx@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox