agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Unify REPACK (CONCURRENTLY) error messages. 2+ messages / 1 participants [nested] [flat]
* pgsql: Unify REPACK (CONCURRENTLY) error messages. @ 2026-09-09 20:46 Masahiko Sawada <msawada@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Masahiko Sawada @ 2026-09-09 20:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Unify REPACK (CONCURRENTLY) error messages. Commit 86f7c82cf102 reported the user catalog table restriction as a detail, but the other checks in check_concurrent_repack_requirements() were still a mix: some were hints, and the details repeated "REPACK (CONCURRENTLY)", which the primary message already names. Report them as details with the same "This operation ..." wording. The one actionable hint, ALTER TABLE ... REPLICA IDENTITY USING INDEX, stays. Backpatch to v19, where REPACK (CONCURRENTLY) was introduced. Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Suggested-by: Alvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/apBIFWzHYOaG0auN%40nathan Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4964c75b0889ab79a268dc1e1027e4dabe0c7dfd Modified Files -------------- contrib/test_decoding/expected/repack.out | 12 ++++++------ src/backend/commands/repack.c | 22 ++++++++-------------- 2 files changed, 14 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Unify REPACK (CONCURRENTLY) error messages. @ 2026-09-09 20:46 Masahiko Sawada <msawada@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Masahiko Sawada @ 2026-09-09 20:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Unify REPACK (CONCURRENTLY) error messages. Commit 86f7c82cf102 reported the user catalog table restriction as a detail, but the other checks in check_concurrent_repack_requirements() were still a mix: some were hints, and the details repeated "REPACK (CONCURRENTLY)", which the primary message already names. Report them as details with the same "This operation ..." wording. The one actionable hint, ALTER TABLE ... REPLICA IDENTITY USING INDEX, stays. Backpatch to v19, where REPACK (CONCURRENTLY) was introduced. Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Suggested-by: Alvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/apBIFWzHYOaG0auN%40nathan Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/94cc8c443a3115531be7abe414dad5034ee3bb57 Modified Files -------------- contrib/test_decoding/expected/repack.out | 12 ++++++------ src/backend/commands/repack.c | 22 ++++++++-------------- 2 files changed, 14 insertions(+), 20 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-09 20:46 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-09 20:46 pgsql: Unify REPACK (CONCURRENTLY) error messages. Masahiko Sawada <msawada@postgresql.org> 2026-09-09 20:46 pgsql: Unify REPACK (CONCURRENTLY) error messages. Masahiko Sawada <msawada@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox