agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Unify REPACK (CONCURRENTLY) error messages.
Date: Wed, 09 Sep 2026 20:46:17 +0000
Message-ID: <E1x4PBQ-00000004B2R-3dBw@gemulon.postgresql.org> (raw)
Unify REPACK (CONCURRENTLY) error messages.
Commit 86f7c82cf102 reported the user catalog table restriction as a
detail, but the other checks in check_concurrent_repack_requirements()
were still a mix: some were hints, and the details repeated
"REPACK (CONCURRENTLY)", which the primary message already names.
Report them as details with the same "This operation ..." wording. The
one actionable hint, ALTER TABLE ... REPLICA IDENTITY USING INDEX,
stays.
Backpatch to v19, where REPACK (CONCURRENTLY) was introduced.
Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Suggested-by: Alvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/apBIFWzHYOaG0auN%40nathan
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/94cc8c443a3115531be7abe414dad5034ee3bb57
Modified Files
--------------
contrib/test_decoding/expected/repack.out | 12 ++++++------
src/backend/commands/repack.c | 22 ++++++++--------------
2 files changed, 14 insertions(+), 20 deletions(-)
view thread (2+ messages)
Message-ID: <E1x4PBQ-00000004B2R-3dBw@gemulon.postgresql.org>
Permalink: ../E1x4PBQ-00000004B2R-3dBw@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4PBQ-00000004B2R-3dBw@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Unify REPACK (CONCURRENTLY) error messages.
In-Reply-To: <E1x4PBQ-00000004B2R-3dBw@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox