agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: test_bitmapset: Improve handling of incorrect inputs
Date: Thu, 10 Sep 2026 02:29:39 +0000
Message-ID: <E1x4UXi-00000004DQd-3KhN@gemulon.postgresql.org> (raw)
test_bitmapset: Improve handling of incorrect inputs
The SQL wrappers of the module relied on stringToNode(), that entirely
trusts its input. This commit applies an extra round of validation, to
prevent the test module from crashing on incorrect inputs, provided
through the SQL functions.
No backpatch, as this is no critical issue.
Author: Zsolt Parragi <zsolt.parragi@percona.com>
Reviewed-by: Greg Burd <greg@burd.me>
Discussion: https://postgr.es/m/CAN4CZFOTQXMZvuPxweO4Fm7+sjrPJUqU-JvYKETLBxuhqgbPjw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/34c11958b6f12a90c0ec9fca3ce502a32280c30d
Modified Files
--------------
.../test_bitmapset/expected/test_bitmapset.out | 24 ++++++++++++
.../modules/test_bitmapset/sql/test_bitmapset.sql | 10 +++++
src/test/modules/test_bitmapset/test_bitmapset.c | 44 ++++++++++++++++++++--
3 files changed, 75 insertions(+), 3 deletions(-)
Message-ID: <E1x4UXi-00000004DQd-3KhN@gemulon.postgresql.org>
Permalink: ../E1x4UXi-00000004DQd-3KhN@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4UXi-00000004DQd-3KhN@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: test_bitmapset: Improve handling of incorrect inputs
In-Reply-To: <E1x4UXi-00000004DQd-3KhN@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox