agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix REPACK command reporting in pg_stat_progress_cluster
Date: Thu, 10 Sep 2026 02:56:05 +0000
Message-ID: <E1x4UxI-00000004Dkb-3Vdm@gemulon.postgresql.org> (raw)
Fix REPACK command reporting in pg_stat_progress_cluster
pg_stat_progress_cluster translates REPACK into VACUUM FULL when
pg_stat_progress_repack.repack_index_relid is zero, and into CLUSTER
otherwise.
Previously, repack_index_relid was set only when an index scan was used.
When REPACK used a sequential scan and sort to order the table by an index,
the field remained zero even though index ordering had been requested. As a
result, pg_stat_progress_cluster incorrectly reported the command as
VACUUM FULL instead of CLUSTER.
Fix this by setting repack_index_relid to the OID of the requested ordering
index when progress reporting starts, regardless of the scan method. This
allows pg_stat_progress_cluster to correctly report REPACK as CLUSTER when
index ordering is requested.
Also update the documentation to clarify the meaning of the index columns
and how REPACK is translated into CLUSTER or VACUUM FULL.
Suggested-by: Fujii Masao <masao.fujii@gmail.com>
Author: Chao Li <lic@highgo.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Discussion: https://postgr.es/m/CAN4CZFMzy2V_wvRCBW5K8=wVCk1-C7nq=8otXO=u+s_1KZHqyA@mail.gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e418e8eb92aa1dccca18b297a85c7ff38a7ee2a0
Modified Files
--------------
doc/src/sgml/monitoring.sgml | 13 +++++++------
src/backend/access/heap/heapam_handler.c | 12 ++----------
src/backend/commands/repack.c | 8 +++++++-
3 files changed, 16 insertions(+), 17 deletions(-)
view thread (2+ messages)
Message-ID: <E1x4UxI-00000004Dkb-3Vdm@gemulon.postgresql.org>
Permalink: ../E1x4UxI-00000004Dkb-3Vdm@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4UxI-00000004Dkb-3Vdm@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix REPACK command reporting in pg_stat_progress_cluster
In-Reply-To: <E1x4UxI-00000004Dkb-3Vdm@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox