agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix REPACK command reporting in pg_stat_progress_cluster 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix REPACK command reporting in pg_stat_progress_cluster @ 2026-09-10 02:55 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Fujii Masao @ 2026-09-10 02:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix REPACK command reporting in pg_stat_progress_cluster pg_stat_progress_cluster translates REPACK into VACUUM FULL when pg_stat_progress_repack.repack_index_relid is zero, and into CLUSTER otherwise. Previously, repack_index_relid was set only when an index scan was used. When REPACK used a sequential scan and sort to order the table by an index, the field remained zero even though index ordering had been requested. As a result, pg_stat_progress_cluster incorrectly reported the command as VACUUM FULL instead of CLUSTER. Fix this by setting repack_index_relid to the OID of the requested ordering index when progress reporting starts, regardless of the scan method. This allows pg_stat_progress_cluster to correctly report REPACK as CLUSTER when index ordering is requested. Also update the documentation to clarify the meaning of the index columns and how REPACK is translated into CLUSTER or VACUUM FULL. Suggested-by: Fujii Masao <masao.fujii@gmail.com> Author: Chao Li <lic@highgo.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com> Discussion: https://postgr.es/m/CAN4CZFMzy2V_wvRCBW5K8=wVCk1-C7nq=8otXO=u+s_1KZHqyA@mail.gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4dd037286e06116f6f4af70a291e215c0a111c24 Modified Files -------------- doc/src/sgml/monitoring.sgml | 13 +++++++------ src/backend/access/heap/heapam_handler.c | 12 ++---------- src/backend/commands/repack.c | 8 +++++++- 3 files changed, 16 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix REPACK command reporting in pg_stat_progress_cluster @ 2026-09-10 02:56 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Fujii Masao @ 2026-09-10 02:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix REPACK command reporting in pg_stat_progress_cluster pg_stat_progress_cluster translates REPACK into VACUUM FULL when pg_stat_progress_repack.repack_index_relid is zero, and into CLUSTER otherwise. Previously, repack_index_relid was set only when an index scan was used. When REPACK used a sequential scan and sort to order the table by an index, the field remained zero even though index ordering had been requested. As a result, pg_stat_progress_cluster incorrectly reported the command as VACUUM FULL instead of CLUSTER. Fix this by setting repack_index_relid to the OID of the requested ordering index when progress reporting starts, regardless of the scan method. This allows pg_stat_progress_cluster to correctly report REPACK as CLUSTER when index ordering is requested. Also update the documentation to clarify the meaning of the index columns and how REPACK is translated into CLUSTER or VACUUM FULL. Suggested-by: Fujii Masao <masao.fujii@gmail.com> Author: Chao Li <lic@highgo.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com> Discussion: https://postgr.es/m/CAN4CZFMzy2V_wvRCBW5K8=wVCk1-C7nq=8otXO=u+s_1KZHqyA@mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e418e8eb92aa1dccca18b297a85c7ff38a7ee2a0 Modified Files -------------- doc/src/sgml/monitoring.sgml | 13 +++++++------ src/backend/access/heap/heapam_handler.c | 12 ++---------- src/backend/commands/repack.c | 8 +++++++- 3 files changed, 16 insertions(+), 17 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-10 02:56 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-10 02:55 pgsql: Fix REPACK command reporting in pg_stat_progress_cluster Fujii Masao <fujii@postgresql.org> 2026-09-10 02:56 pgsql: Fix REPACK command reporting in pg_stat_progress_cluster Fujii Masao <fujii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox