agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgbench: Improve handling of NULL in \gset and \aset
Date: Thu, 10 Sep 2026 04:11:22 +0000
Message-ID: <E1x4W88-00000004EEa-3yd1@gemulon.postgresql.org> (raw)
pgbench: Improve handling of NULL in \gset and \aset
Previously, readCommandResponse() stored every column with PQgetvalue(),
which returns an empty string for the SQL NULL value. An empty string
is not a valid value in the pgbench expression language, and when
returned by the server it was also indistinguishable from a NULL.
When receiving a value, pgbench now checks for PQgetisnull() and sets a
NULL value with setNullValue() before saving it. This behavior is more
consistent with \set, making the result saved testable with IS NULL.
This is a quality-of-life improvement, so no backpatch is done.
Author: Shinya Kato <shinya11.kato@gmail.com>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-by: Shihao Zhong <zhong950419@gmail.com>
Discussion: https://postgr.es/m/CAOzEurT9J9QMmpJt_8pWZCziNYCUHOD=c-hoccOVYJLc_VxVRg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d8304bc661c29600f82ba62719457837edf47b08
Modified Files
--------------
src/bin/pgbench/pgbench.c | 19 ++++++++++++++++---
src/bin/pgbench/t/001_pgbench_with_server.pl | 14 ++++++++++++++
2 files changed, 30 insertions(+), 3 deletions(-)
Message-ID: <E1x4W88-00000004EEa-3yd1@gemulon.postgresql.org>
Permalink: ../E1x4W88-00000004EEa-3yd1@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4W88-00000004EEa-3yd1@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pgbench: Improve handling of NULL in \gset and \aset
In-Reply-To: <E1x4W88-00000004EEa-3yd1@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox