agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove stale comment and redundant assignment in BuildTupleHashT
Date: Thu, 10 Sep 2026 07:13:03 +0000
Message-ID: <E1x4Yxy-00000004FnL-1EX5@gemulon.postgresql.org> (raw)
Remove stale comment and redundant assignment in BuildTupleHashTable()
Since commit bf6c614a2f2, BuildTupleHashTable() has created the table
slot unconditionally rather than on the first lookup. However, the
comment still described the old behavior, and tableslot was still
redundantly initialized to NULL before being assigned the new slot.
Remove the stale comment and redundant assignment.
Author: Tatsuya Kawata <kawatatatsuya0913@gmail.com>
Reviewed-by: Quan Zongliang <quanzongliang@yeah.net>
Discussion: https://postgr.es/m/CAHza6qfduAcYc3HdXP5DYscNstz0ic6ctHTNH70VL1Uy-nJ6zg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bd9d6ffa1aea612cc8da31f7b30d5573747b86f8
Modified Files
--------------
src/backend/executor/execGrouping.c | 1 -
1 file changed, 1 deletion(-)
Message-ID: <E1x4Yxy-00000004FnL-1EX5@gemulon.postgresql.org>
Permalink: ../E1x4Yxy-00000004FnL-1EX5@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4Yxy-00000004FnL-1EX5@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove stale comment and redundant assignment in BuildTupleHashT
In-Reply-To: <E1x4Yxy-00000004FnL-1EX5@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox