agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Clarify RI tuple-lock result handling comments 2+ messages / 1 participants [nested] [flat]
* pgsql: Clarify RI tuple-lock result handling comments @ 2026-09-10 08:18 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Langote @ 2026-09-10 08:18 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clarify RI tuple-lock result handling comments Explain that returning false for TM_SelfModified follows ExecLockRows(), which skips such tuples. This differs from TM_Updated, which is unexpected in READ COMMITTED with FIND_LAST_VERSION. Also remove "fall through to error" from the TM_Updated comment, since the code calls elog(ERROR) directly. Reported-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/CAA4eK1Lk1DfgiFPL-HccZm-Nm+exg+FcsODH8KPw6BOBuzfHtA@mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ca3fd678f47becc5b84e0b027b2f062c5ad05b2b Modified Files -------------- src/backend/utils/adt/ri_triggers.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Clarify RI tuple-lock result handling comments @ 2026-09-10 08:18 Amit Langote <amitlan@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Langote @ 2026-09-10 08:18 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clarify RI tuple-lock result handling comments Explain that returning false for TM_SelfModified follows ExecLockRows(), which skips such tuples. This differs from TM_Updated, which is unexpected in READ COMMITTED with FIND_LAST_VERSION. Also remove "fall through to error" from the TM_Updated comment, since the code calls elog(ERROR) directly. Reported-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/CAA4eK1Lk1DfgiFPL-HccZm-Nm+exg+FcsODH8KPw6BOBuzfHtA@mail.gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5e34fe3580559c3eee82a32308d8a387c57e8dfd Modified Files -------------- src/backend/utils/adt/ri_triggers.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-10 08:18 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-10 08:18 pgsql: Clarify RI tuple-lock result handling comments Amit Langote <amitlan@postgresql.org> 2026-09-10 08:18 pgsql: Clarify RI tuple-lock result handling comments Amit Langote <amitlan@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox