agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clarify RI tuple-lock result handling comments
Date: Thu, 10 Sep 2026 08:18:29 +0000
Message-ID: <E1x4ZzH-00000004GMl-41YN@gemulon.postgresql.org> (raw)
Clarify RI tuple-lock result handling comments
Explain that returning false for TM_SelfModified follows ExecLockRows(),
which skips such tuples. This differs from TM_Updated, which is
unexpected in READ COMMITTED with FIND_LAST_VERSION.
Also remove "fall through to error" from the TM_Updated comment, since
the code calls elog(ERROR) directly.
Reported-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/CAA4eK1Lk1DfgiFPL-HccZm-Nm+exg+FcsODH8KPw6BOBuzfHtA@mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5e34fe3580559c3eee82a32308d8a387c57e8dfd
Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
view thread (2+ messages)
Message-ID: <E1x4ZzH-00000004GMl-41YN@gemulon.postgresql.org>
Permalink: ../E1x4ZzH-00000004GMl-41YN@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4ZzH-00000004GMl-41YN@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Clarify RI tuple-lock result handling comments
In-Reply-To: <E1x4ZzH-00000004GMl-41YN@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox