agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Revert 87b2968df0 and 0a90df58cf. 2+ messages / 1 participants [nested] [flat]
* pgsql: Revert 87b2968df0 and 0a90df58cf. @ 2026-09-11 01:13 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-09-11 01:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert 87b2968df0 and 0a90df58cf. Those changes were intended to avoid dependencies on the global libc locale settings by basing identifier casefolding on the default locale. They introduced an unintentional behavior difference for the builtin provider with locale C and a single-byte encoding. Instead of fixing that edge case, just revert the changes. The identifier casefolding behavior has always been based on the global libc locale, and clients make an effort to use the same rules. Until we have a plan to change that, provider-specific identifier casefolding doesn't make sense. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20260826225510.10.noahmisch@microsoft.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ba9e747c49a6c09975db04bee64b22c0c304fa12 Modified Files -------------- src/backend/parser/scansup.c | 36 ++++++++++----- src/backend/utils/adt/pg_locale.c | 24 ---------- src/backend/utils/adt/pg_locale_builtin.c | 2 - src/backend/utils/adt/pg_locale_icu.c | 76 +------------------------------ src/backend/utils/adt/pg_locale_libc.c | 33 -------------- src/include/utils/pg_locale.h | 8 ---- 6 files changed, 25 insertions(+), 154 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Revert 87b2968df0 and 0a90df58cf. @ 2026-09-11 01:14 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-09-11 01:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert 87b2968df0 and 0a90df58cf. Those changes were intended to avoid dependencies on the global libc locale settings by basing identifier casefolding on the default locale. They introduced an unintentional behavior difference for the builtin provider with locale C and a single-byte encoding. Instead of fixing that edge case, just revert the changes. The identifier casefolding behavior has always been based on the global libc locale, and clients make an effort to use the same rules. Until we have a plan to change that, provider-specific identifier casefolding doesn't make sense. Reported-by: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20260826225510.10.noahmisch@microsoft.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c58566d06f964166370e93f1bc8444a534bd0bd2 Modified Files -------------- src/backend/parser/scansup.c | 36 ++++++++++----- src/backend/utils/adt/pg_locale.c | 24 ---------- src/backend/utils/adt/pg_locale_builtin.c | 2 - src/backend/utils/adt/pg_locale_icu.c | 76 +------------------------------ src/backend/utils/adt/pg_locale_libc.c | 33 -------------- src/include/utils/pg_locale.h | 8 ---- 6 files changed, 25 insertions(+), 154 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-11 01:14 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-11 01:13 pgsql: Revert 87b2968df0 and 0a90df58cf. Jeff Davis <jdavis@postgresql.org> 2026-09-11 01:14 pgsql: Revert 87b2968df0 and 0a90df58cf. Jeff Davis <jdavis@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox