agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert 87b2968df0 and 0a90df58cf.
Date: Fri, 11 Sep 2026 01:14:02 +0000
Message-ID: <E1x4pq5-00000004MrC-1NnH@gemulon.postgresql.org> (raw)
Revert 87b2968df0 and 0a90df58cf.
Those changes were intended to avoid dependencies on the global libc
locale settings by basing identifier casefolding on the default
locale. They introduced an unintentional behavior difference for the
builtin provider with locale C and a single-byte encoding.
Instead of fixing that edge case, just revert the changes. The
identifier casefolding behavior has always been based on the global
libc locale, and clients make an effort to use the same rules. Until
we have a plan to change that, provider-specific identifier
casefolding doesn't make sense.
Reported-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/20260826225510.10.noahmisch@microsoft.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c58566d06f964166370e93f1bc8444a534bd0bd2
Modified Files
--------------
src/backend/parser/scansup.c | 36 ++++++++++-----
src/backend/utils/adt/pg_locale.c | 24 ----------
src/backend/utils/adt/pg_locale_builtin.c | 2 -
src/backend/utils/adt/pg_locale_icu.c | 76 +------------------------------
src/backend/utils/adt/pg_locale_libc.c | 33 --------------
src/include/utils/pg_locale.h | 8 ----
6 files changed, 25 insertions(+), 154 deletions(-)
view thread (2+ messages)
Message-ID: <E1x4pq5-00000004MrC-1NnH@gemulon.postgresql.org>
Permalink: ../E1x4pq5-00000004MrC-1NnH@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4pq5-00000004MrC-1NnH@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revert 87b2968df0 and 0a90df58cf.
In-Reply-To: <E1x4pq5-00000004MrC-1NnH@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox