agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add static assertion to track the no-padding rule of varatt_exte
Date: Fri, 11 Sep 2026 02:05:22 +0000
Message-ID: <E1x4qdl-00000004NCE-2RR6@gemulon.postgresql.org> (raw)
Add static assertion to track the no-padding rule of varatt_external_oid
varatt_external_oid (varatt_external in v19 and older branches) having
no padding is a rule that has been implied for years, as pointers of
this structure may be compared using memcpy().
I doubt that anybody is going to break this rule as varatt_external is
old enough that it could vote in most countries, but this makes varatt.h
more consistent for a follow-up change that introduces a second on-disk
external TOAST pointer, and it's free to have a compile-time rule.
Suggested-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Discussion: https://postgr.es/m/CALj2ACVG9cjxr-0jb8PP_Vb7vJvVGBVM_fQ2srt4CpyURpfYhQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1497ea77edd2ce261670f117301dc4da33d4c894
Modified Files
--------------
src/include/varatt.h | 4 ++++
1 file changed, 4 insertions(+)
Message-ID: <E1x4qdl-00000004NCE-2RR6@gemulon.postgresql.org>
Permalink: ../E1x4qdl-00000004NCE-2RR6@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4qdl-00000004NCE-2RR6@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add static assertion to track the no-padding rule of varatt_exte
In-Reply-To: <E1x4qdl-00000004NCE-2RR6@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox