agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fall back to SPI for RI checks with mismatched index collations
Date: Fri, 11 Sep 2026 08:51:25 +0000
Message-ID: <E1x4wyh-00000004PYd-492D@gemulon.postgresql.org> (raw)
Fall back to SPI for RI checks with mismatched index collations
The fast path probes using the referenced index's collation. When that
collation differs from the referenced column's, it can reject valid
references or accept invalid ones. Changing the scan key's collation
is not sufficient, since btree navigation must use the ordering under
which the index was built.
Cache index eligibility lazily after locking the referenced table,
reloading the constraint information, and opening the index. Compare
index and column collations using the held relation descriptors, and
fall back to SPI on a mismatch. Also move the btree eligibility check
here, avoiding a lookup of an index that REINDEX CONCURRENTLY could
drop before the referenced-table lock is acquired.
Cache both acceptance and rejection until the constraint information
is reloaded, so subsequent rows need not repeat the comparisons. Check
before probing or buffering any row. If batch entry initialization
rejects the index, remove that entry while preserving any other pending
checks.
Add ICU regression coverage for per-row validation, ordinary inserts,
reordered index columns, both directions of collation mismatch, and
fallback while another foreign key check is pending.
Reported-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/CAA4eK1Lk1DfgiFPL-HccZm-Nm+exg+FcsODH8KPw6BOBuzfHtA@mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0b0b413292161cf709b9dbc4d5adee23be53ee34
Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 157 ++++++++++++++++++++-----
src/test/regress/expected/collate.icu.utf8.out | 64 ++++++++++
src/test/regress/sql/collate.icu.utf8.sql | 60 ++++++++++
src/tools/pgindent/typedefs.list | 1 +
4 files changed, 254 insertions(+), 28 deletions(-)
view thread (2+ messages)
Message-ID: <E1x4wyh-00000004PYd-492D@gemulon.postgresql.org>
Permalink: ../E1x4wyh-00000004PYd-492D@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x4wyh-00000004PYd-492D@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fall back to SPI for RI checks with mismatched index collations
In-Reply-To: <E1x4wyh-00000004PYd-492D@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox