agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: pg_ctl: Silence warnings about unused global variables 6+ messages / 1 participants [nested] [flat]
* pgsql: pg_ctl: Silence warnings about unused global variables @ 2026-09-11 17:25 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-09-11 17:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_ctl: Silence warnings about unused global variables Several global variables are only used in Windows build. This causes -Wunused-but-set-global warnings that the new clang 23 enables via -Wall. This commit marks these with an unused attribute to silence the warnings. (In the master branch, this is addressed differently, but for backpatching, this just silences the warnings without any behavior change.) Reviewed-by: Andreas Karlsson <andreas@proxel.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fbaeb88978f023e724bef1ce74fc46c65841401c Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_ctl: Silence warnings about unused global variables @ 2026-09-11 17:36 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-09-11 17:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_ctl: Silence warnings about unused global variables Several global variables are only used in Windows build. This causes -Wunused-but-set-global warnings that the new clang 23 enables via -Wall. This commit marks these with an unused attribute to silence the warnings. (In the master branch, this is addressed differently, but for backpatching, this just silences the warnings without any behavior change.) Reviewed-by: Andreas Karlsson <andreas@proxel.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/810e63b1443c928fa7889054c46d0f3df10b32ef Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_ctl: Silence warnings about unused global variables @ 2026-09-11 18:01 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-09-11 18:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_ctl: Silence warnings about unused global variables Several global variables are only used in Windows build. This causes -Wunused-but-set-global warnings that the new clang 23 enables via -Wall. This commit marks these with an unused attribute to silence the warnings. (In the master branch, this is addressed differently, but for backpatching, this just silences the warnings without any behavior change.) Reviewed-by: Andreas Karlsson <andreas@proxel.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3317dc47241dca90466650d36a0cad40c97bb0f7 Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_ctl: Silence warnings about unused global variables @ 2026-09-11 18:55 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-09-11 18:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_ctl: Silence warnings about unused global variables Several global variables are only used in Windows build. This causes -Wunused-but-set-global warnings that the new clang 23 enables via -Wall. This commit marks these with an unused attribute to silence the warnings. (In the master branch, this is addressed differently, but for backpatching, this just silences the warnings without any behavior change.) Reviewed-by: Andreas Karlsson <andreas@proxel.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8e4d7e7baa46fde0cc140e475a3b2647e72580af Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_ctl: Silence warnings about unused global variables @ 2026-09-11 19:09 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-09-11 19:09 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_ctl: Silence warnings about unused global variables Several global variables are only used in Windows build. This causes -Wunused-but-set-global warnings that the new clang 23 enables via -Wall. This commit marks these with an unused attribute to silence the warnings. (In the master branch, this is addressed differently, but for backpatching, this just silences the warnings without any behavior change.) Reviewed-by: Andreas Karlsson <andreas@proxel.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8032e8e89456319bc0384c322ebf53ffd666d329 Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: pg_ctl: Silence warnings about unused global variables @ 2026-09-11 19:33 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-09-11 19:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_ctl: Silence warnings about unused global variables Several global variables are only used in Windows build. This causes -Wunused-but-set-global warnings that the new clang 23 enables via -Wall. This commit marks these with an unused attribute to silence the warnings. (In the master branch, this is addressed differently, but for backpatching, this just silences the warnings without any behavior change.) Reviewed-by: Andreas Karlsson <andreas@proxel.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ddc22e8084918807a6c5e258bbc5c474a85ea274 Modified Files -------------- src/bin/pg_ctl/pg_ctl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-09-11 19:33 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-11 17:25 pgsql: pg_ctl: Silence warnings about unused global variables Peter Eisentraut <peter@eisentraut.org> 2026-09-11 17:36 pgsql: pg_ctl: Silence warnings about unused global variables Peter Eisentraut <peter@eisentraut.org> 2026-09-11 18:01 pgsql: pg_ctl: Silence warnings about unused global variables Peter Eisentraut <peter@eisentraut.org> 2026-09-11 18:55 pgsql: pg_ctl: Silence warnings about unused global variables Peter Eisentraut <peter@eisentraut.org> 2026-09-11 19:09 pgsql: pg_ctl: Silence warnings about unused global variables Peter Eisentraut <peter@eisentraut.org> 2026-09-11 19:33 pgsql: pg_ctl: Silence warnings about unused global variables Peter Eisentraut <peter@eisentraut.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox