agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_ctl: Silence warnings about unused global variables
Date: Fri, 11 Sep 2026 17:36:14 +0000
Message-ID: <E1x55Ab-00000004Stj-1lXe@gemulon.postgresql.org> (raw)
pg_ctl: Silence warnings about unused global variables
Several global variables are only used in Windows build. This causes
-Wunused-but-set-global warnings that the new clang 23 enables via
-Wall.
This commit marks these with an unused attribute to silence the
warnings.
(In the master branch, this is addressed differently, but for
backpatching, this just silences the warnings without any behavior
change.)
Reviewed-by: Andreas Karlsson <andreas@proxel.se>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/810e63b1443c928fa7889054c46d0f3df10b32ef
Modified Files
--------------
src/bin/pg_ctl/pg_ctl.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
view thread (6+ messages) latest in thread
Message-ID: <E1x55Ab-00000004Stj-1lXe@gemulon.postgresql.org>
Permalink: ../E1x55Ab-00000004Stj-1lXe@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x55Ab-00000004Stj-1lXe@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_ctl: Silence warnings about unused global variables
In-Reply-To: <E1x55Ab-00000004Stj-1lXe@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox