agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unused global variables
Date: Fri, 11 Sep 2026 19:09:43 +0000
Message-ID: <E1x56d4-00000004TYJ-3d9t@gemulon.postgresql.org> (raw)
Remove unused global variables
The new clang 23 has a new warning about set-but-unused
static (internal-linkage) global variables: -Wunused-but-set-global,
which is activated in PostgreSQL builds via -Wall. This triggers a
few warnings in PostgreSQL code. This commit removes several such
variables that were either never used or whose last use was removed
some time ago.
For pq_init_crypto_lib, we apply the same #ifdef HAVE_CRYPTO_LOCK that
the other uses of the variable already have, so that the variable is
either fully used or fully nonexistent, depending on the
configuration, not half-way.
Reinit was already documented in a comment as dead code, and it was
removed in a later branch. To minimize the surgery there, just add an
unused attribute to silence the warning.
Reviewed-by: Andreas Karlsson <andreas@proxel.se>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/eb013f9d-2247-444e-8815-9d17b4ce78e7%40eisentraut.org
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d61f79b747c5cc351c8129f33ea28dc16f3660ec
Modified Files
--------------
src/backend/access/transam/xlog.c | 9 ---------
src/backend/postmaster/postmaster.c | 5 +----
src/backend/utils/adt/jsonpath_scan.l | 2 --
src/bin/pg_dump/pg_dump_sort.c | 2 --
src/interfaces/libpq/fe-secure-openssl.c | 4 ++++
5 files changed, 5 insertions(+), 17 deletions(-)
view thread (7+ messages) latest in thread
Message-ID: <E1x56d4-00000004TYJ-3d9t@gemulon.postgresql.org>
Permalink: ../E1x56d4-00000004TYJ-3d9t@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x56d4-00000004TYJ-3d9t@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove unused global variables
In-Reply-To: <E1x56d4-00000004TYJ-3d9t@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox