agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Revert "Use -isystem for LLVM include directories"
Date: Sat, 12 Sep 2026 13:52:40 +0000
Message-ID: <E1x5O9o-000000001fn-3B2v@gemulon.postgresql.org> (raw)
Revert "Use -isystem for LLVM include directories"
This reverts commit 704ef84ef232e02e241071b2faf0541d155c6b62.
The configure solution in that commit doesn't work if llvm-config
returns a system directory such as /usr/include. The resulting
-isystem /usr/include puts the C headers before the C++ headers in the
include file order, which is not supposed to be done and causes
failures. (Using -I /usr/include doesn't have that problem because it
is handled specially by the compiler.) Per buildfarm members
hippopotamus and jay.
The meson solution does work because it specifically filters out
system includes. This logic could theoretically be ported to
configure, but that would be a separate undertaking.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7a0aa99e51c7a3263e6ee45f19f270ddae430a92
Modified Files
--------------
config/llvm.m4 | 7 ++-----
configure | 7 ++-----
meson.build | 5 +----
3 files changed, 5 insertions(+), 14 deletions(-)
Message-ID: <E1x5O9o-000000001fn-3B2v@gemulon.postgresql.org>
Permalink: ../E1x5O9o-000000001fn-3B2v@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x5O9o-000000001fn-3B2v@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Revert "Use -isystem for LLVM include directories"
In-Reply-To: <E1x5O9o-000000001fn-3B2v@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox