agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve error message for checksum state in pg_upgrade
Date: Mon, 14 Sep 2026 13:34:14 +0000
Message-ID: <E1x66p4-00000000I6U-2pG9@gemulon.postgresql.org> (raw)
Improve error message for checksum state in pg_upgrade
When attempting to upgrade a cluster which is an inprogress state, the
same error message was used regardless of which state it was. Fix by
using different error messages for the different inprogress states.
Found by Noah using AI assisted review with Claude. Backpatch to v19
where the online checksums feature was introduced.
Reported-by: Noah Misch <noah@leadboat.com>
Discussion: https://postgr.es/m/E15AC050-C4B5-488D-BB2D-3C7AC9F89EA8@yesql.se
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9a45131b7cf3b573d1b15a093a3cc80869814cbe
Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
view thread (3+ messages)
Message-ID: <E1x66p4-00000000I6U-2pG9@gemulon.postgresql.org>
Permalink: ../E1x66p4-00000000I6U-2pG9@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x66p4-00000000I6U-2pG9@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve error message for checksum state in pg_upgrade
In-Reply-To: <E1x66p4-00000000I6U-2pG9@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox