agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix ignored return value in test code
Date: Mon, 14 Sep 2026 19:42:07 +0000
Message-ID: <E1x6CZ5-00000000KZv-1KWI@gemulon.postgresql.org> (raw)
Fix ignored return value in test code
The perlcritic check in the buildfarm alerted that the new test suites
for online checksums didn't check the return value from read(). Fix by
checking the return and ensuring the read call didn't fail. Per build-
farm member crake.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2026-09-14%2015%3A04%3A18
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6e70bef24e480eed3e0af0480c1bc7c0208833c8
Modified Files
--------------
src/test/modules/test_checksums/t/016_promote_enable_crash.pl | 3 ++-
src/test/modules/test_checksums/t/017_restartpoint_race.pl | 3 ++-
src/test/modules/test_checksums/t/018_enable_crash_windows.pl | 9 ++++++---
3 files changed, 10 insertions(+), 5 deletions(-)
Message-ID: <E1x6CZ5-00000000KZv-1KWI@gemulon.postgresql.org>
Permalink: ../E1x6CZ5-00000000KZv-1KWI@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x6CZ5-00000000KZv-1KWI@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix ignored return value in test code
In-Reply-To: <E1x6CZ5-00000000KZv-1KWI@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox