agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add support for toast_value_type=oid8
Date: Mon, 14 Sep 2026 23:39:15 +0000
Message-ID: <E1x6GGZ-00000000M1t-1wD3@gemulon.postgresql.org> (raw)
Add support for toast_value_type=oid8
This commit adds the possibility to define TOAST tables with oid8 as
their chunk_id, based on the reloption toast_value_type. All the
external TOAST pointers still rely on varatt_external_oid and a single
vartag. The values inserted in the oid8 TOAST tables are fed from the
OID8 value generator, casted to OID for now, as we do not have a
vartag_external able to store Oid8 values yet.
An upcoming commit will add support for a new vartag_external and its
associated structures, with the code being able to use a different
on-disk external TOAST pointer depending on the attribute type of
chunk_id defined in TOAST relations.
All the changes done here are mechanical, mostly around the TOAST code
that needs to be able to do chunk_id lookups based on the two types now
supported.
Bump catalog version.
Author: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Greg Burd <greg@burd.me>
Reviewed-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Yugo Nagata <nagata@sraoss.co.jp>
Discussion: https://postgr.es/m/af19kUjwjhaoUTLn@paquier.xy
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a625fc570c22e199471e1a2656e2c32b8dc0c0fd
Modified Files
--------------
contrib/amcheck/verify_heapam.c | 13 ++--
doc/src/sgml/ref/create_table.sgml | 5 +-
doc/src/sgml/storage.sgml | 7 +-
src/backend/access/common/reloptions.c | 3 +-
src/backend/access/common/toast_internals.c | 88 +++++++++++++++++--------
src/backend/access/heap/heaptoast.c | 7 +-
src/backend/catalog/toasting.c | 25 ++++++-
src/backend/replication/logical/reorderbuffer.c | 9 ++-
src/include/access/toast_internals.h | 4 ++
src/include/catalog/pg_opclass.dat | 3 +-
src/include/utils/rel.h | 1 +
src/test/regress/expected/reloptions.out | 15 ++++-
src/test/regress/sql/reloptions.sql | 8 +++
13 files changed, 142 insertions(+), 46 deletions(-)
Message-ID: <E1x6GGZ-00000000M1t-1wD3@gemulon.postgresql.org>
Permalink: ../E1x6GGZ-00000000M1t-1wD3@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x6GGZ-00000000M1t-1wD3@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add support for toast_value_type=oid8
In-Reply-To: <E1x6GGZ-00000000M1t-1wD3@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox