agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Tweak tests related to oid8 in amcheck and test_decoding
Date: Wed, 16 Sep 2026 01:11:34 +0000
Message-ID: <E1x6eBS-00000000VxR-0oOD@gemulon.postgresql.org> (raw)
Tweak tests related to oid8 in amcheck and test_decoding
Some of the tests introduced by c68cba09dd7f in these two modules want
to rely on out-of-line values (compressed and not compressed), but the
values inserted that should be compressed were not (STORAGE EXTENDED).
The tests are updated to do what they should, reusing a cheap trick to
ensure out-of-line values coming from a different test in test_decoding.
Some checks are added to ensure that the expected set of values is
inserted.
Reported-by: Rui Zhao <zhaorui126@gmail.com>
Discussion: https://postgr.es/m/CAHWVJhGxVc4CpDd+mb=6YbeL2KHDUtsUC=R68y7NeMg1cO8QMg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/87c6ef14f11705e690a9c54f91e0d97977ce333f
Modified Files
--------------
contrib/amcheck/expected/check_heap.out | 33 ++++++++++++++++++++++++--------
contrib/amcheck/sql/check_heap.sql | 21 ++++++++++++--------
contrib/test_decoding/expected/toast.out | 20 +++++++++++++++----
contrib/test_decoding/sql/toast.sql | 10 ++++++++--
4 files changed, 62 insertions(+), 22 deletions(-)
Message-ID: <E1x6eBS-00000000VxR-0oOD@gemulon.postgresql.org>
Permalink: ../E1x6eBS-00000000VxR-0oOD@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x6eBS-00000000VxR-0oOD@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Tweak tests related to oid8 in amcheck and test_decoding
In-Reply-To: <E1x6eBS-00000000VxR-0oOD@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox