agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Suppress progress reporting when creating TOAST indexes 2+ messages / 1 participants [nested] [flat]
* pgsql: Suppress progress reporting when creating TOAST indexes @ 2026-09-16 09:40 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Fujii Masao @ 2026-09-16 09:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Suppress progress reporting when creating TOAST indexes Previously, when REPACK, CLUSTER, or VACUUM FULL created a transient TOAST table, index_rebuild_count in pg_stat_progress_repack and pg_stat_progress_cluster reported 2 before any indexes on the main table had been rebuilt. This could mislead users monitoring the operation. This happened because creating the TOAST index writes the CREATE INDEX phase to the same progress slot used for the index rebuild count of the enclosing command. Fix this by passing INDEX_CREATE_SUPPRESS_PROGRESS when creating a TOAST index, preserving the progress information of the enclosing command and keeping the count at zero until the main-table indexes are rebuilt. Author: Adam Lee <adam8157@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/aj4gJQMba0kClQmj@Mac Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4b445479f9e0ea5039c782e9dab35ec9af6b6d4d Modified Files -------------- src/backend/catalog/toasting.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Suppress progress reporting when creating TOAST indexes @ 2026-09-16 09:40 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Fujii Masao @ 2026-09-16 09:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Suppress progress reporting when creating TOAST indexes Previously, when REPACK, CLUSTER, or VACUUM FULL created a transient TOAST table, index_rebuild_count in pg_stat_progress_repack and pg_stat_progress_cluster reported 2 before any indexes on the main table had been rebuilt. This could mislead users monitoring the operation. This happened because creating the TOAST index writes the CREATE INDEX phase to the same progress slot used for the index rebuild count of the enclosing command. Fix this by passing INDEX_CREATE_SUPPRESS_PROGRESS when creating a TOAST index, preserving the progress information of the enclosing command and keeping the count at zero until the main-table indexes are rebuilt. Author: Adam Lee <adam8157@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/aj4gJQMba0kClQmj@Mac Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8a1b5b3d43883454d3438674eaca71184f7e6dec Modified Files -------------- src/backend/catalog/toasting.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-16 09:40 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-16 09:40 pgsql: Suppress progress reporting when creating TOAST indexes Fujii Masao <fujii@postgresql.org> 2026-09-16 09:40 pgsql: Suppress progress reporting when creating TOAST indexes Fujii Masao <fujii@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox