agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Suppress progress reporting when creating TOAST indexes
Date: Wed, 16 Sep 2026 09:40:17 +0000
Message-ID: <E1x6m7l-00000000ZFa-14il@gemulon.postgresql.org> (raw)
Suppress progress reporting when creating TOAST indexes
Previously, when REPACK, CLUSTER, or VACUUM FULL created a transient TOAST
table, index_rebuild_count in pg_stat_progress_repack and
pg_stat_progress_cluster reported 2 before any indexes on the main table
had been rebuilt. This could mislead users monitoring the operation.
This happened because creating the TOAST index writes the CREATE INDEX phase
to the same progress slot used for the index rebuild count of the enclosing
command.
Fix this by passing INDEX_CREATE_SUPPRESS_PROGRESS when creating a TOAST
index, preserving the progress information of the enclosing command and
keeping the count at zero until the main-table indexes are rebuilt.
Author: Adam Lee <adam8157@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/aj4gJQMba0kClQmj@Mac
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/8a1b5b3d43883454d3438674eaca71184f7e6dec
Modified Files
--------------
src/backend/catalog/toasting.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
view thread (2+ messages)
Message-ID: <E1x6m7l-00000000ZFa-14il@gemulon.postgresql.org>
Permalink: ../E1x6m7l-00000000ZFa-14il@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x6m7l-00000000ZFa-14il@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Suppress progress reporting when creating TOAST indexes
In-Reply-To: <E1x6m7l-00000000ZFa-14il@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox