pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix online checksums revert leftovers
Date: Wed, 16 Sep 2026 19:00:10 +0000
Message-ID: <E1x6ura-00000000eDi-0GNz@gemulon.postgresql.org> (raw)

Fix online checksums revert leftovers

When reverting the online checksums feature in commit c05d5ce12366f10
I accidentally left the data checksum column in pg_control_checkpoint,
removed setting the checksum init in pg_control_init and omitted the
XLOG_PAGE_MAGIC bump required.

Reported-by: Fujii Masao <masao.fujii@gmail.com>
Reported-by: Manuel Reyes Bravo <manuelreyesbravo@gmail.com>
Reported-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/CAHGQGwH-wHTq4xd2dedEj0niDHkezcCT_OLmMpGp9NEHW4Dvkw@mail.gmail.com

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4a9a6c5a69c45ba74c694ccb1ff5921dd09a6676

Modified Files
--------------
src/backend/access/transam/xlog.c  | 1 +
src/include/access/xlog_internal.h | 2 +-
src/include/catalog/catversion.h   | 2 +-
src/include/catalog/pg_proc.dat    | 6 +++---
4 files changed, 6 insertions(+), 5 deletions(-)



Message-ID: <E1x6ura-00000000eDi-0GNz@gemulon.postgresql.org>
Permalink:  ../E1x6ura-00000000eDi-0GNz@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1x6ura-00000000eDi-0GNz@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix online checksums revert leftovers
  In-Reply-To: <E1x6ura-00000000eDi-0GNz@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox