agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Have the REPACK decoding worker use timeout values from the stee
Date: Thu, 17 Sep 2026 10:48:03 +0000
Message-ID: <E1x79et-0000000068F-31PK@gemulon.postgresql.org> (raw)
Have the REPACK decoding worker use timeout values from the steering backend
The worker connects as the table owner in a new session, so a role- or
database-level lock_timeout and transaction_timeout unhelpfully apply to
it, possibly canceling the wait for older transactions. This cannot be
overridden by the REPACK calling session. Fix by passing the timeout
values from the steering backend via the DecodingWorkerShared struct and
adopting these values in the worker; this way, values from session-local
SET reach the worker too.
In passing, remove a pointless member from the same struct.
Author: Shihao Zhong <zhong950419@gmail.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/CAGRkXqTYaBjFvjtjPb1+=sZWvt93=2c472bmM+xdG7w9ZvAydA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a62ff0829d6b151a7107f6ae7f7f90b52405a247
Modified Files
--------------
src/backend/commands/repack.c | 5 ++++-
src/backend/commands/repack_worker.c | 11 ++++++++++-
src/include/commands/repack_internal.h | 5 ++++-
3 files changed, 18 insertions(+), 3 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1x79et-0000000068F-31PK@gemulon.postgresql.org>
Permalink: ../E1x79et-0000000068F-31PK@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x79et-0000000068F-31PK@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Have the REPACK decoding worker use timeout values from the stee
In-Reply-To: <E1x79et-0000000068F-31PK@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox