agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Don't quote the relation name twice in EXCEPT clause errors. 2+ messages / 1 participants [nested] [flat]
* pgsql: Don't quote the relation name twice in EXCEPT clause errors. @ 2026-09-18 05:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2026-09-18 05:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't quote the relation name twice in EXCEPT clause errors. Commit a49b9cfd72 began reporting the EXCEPT clause relation with a schema-qualified name that quotes identifiers when needed, inside a message that already puts the name in quotes. So a schema or relation name that needs quoting came out quoted twice. Fix by building the qualified name as "%s.%s" without identifier quoting, so it renders like the qualified names in other backend error messages. The message text, and so its translations, is unchanged. RelationGetQualifiedRelationName() has no callers left, so remove it. Author: Manuel Reyes Bravo <manuelreyesbravo@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Vignesh C <vignesh21@gmail.com> Reviewed-by: Peter Smith <smithpb2250@gmail.com> Reviewed-by: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/CAHGQGwHfESBexa7fq99EvFCf31av=O9h9udnw22ymxmm6LMZzw@mail.gmail.com Backpatch-through: 19, where it was introduced Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/926627bf9021137af66ac3bf21d1595af64ec66b Modified Files -------------- src/backend/catalog/pg_publication.c | 8 +++++++- src/backend/utils/cache/relcache.c | 10 ---------- src/include/utils/relcache.h | 1 - src/test/regress/expected/publication.out | 7 ++++++- src/test/regress/sql/publication.sql | 5 ++++- 5 files changed, 17 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Don't quote the relation name twice in EXCEPT clause errors. @ 2026-09-18 05:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2026-09-18 05:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't quote the relation name twice in EXCEPT clause errors. Commit a49b9cfd72 began reporting the EXCEPT clause relation with a schema-qualified name that quotes identifiers when needed, inside a message that already puts the name in quotes. So a schema or relation name that needs quoting came out quoted twice. Fix by building the qualified name as "%s.%s" without identifier quoting, so it renders like the qualified names in other backend error messages. The message text, and so its translations, is unchanged. RelationGetQualifiedRelationName() has no callers left, so remove it. Author: Manuel Reyes Bravo <manuelreyesbravo@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Vignesh C <vignesh21@gmail.com> Reviewed-by: Peter Smith <smithpb2250@gmail.com> Reviewed-by: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/CAHGQGwHfESBexa7fq99EvFCf31av=O9h9udnw22ymxmm6LMZzw@mail.gmail.com Backpatch-through: 19, where it was introduced Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/644e00f7f2dc992ed368eac37693be5458b869d9 Modified Files -------------- src/backend/catalog/pg_publication.c | 8 +++++++- src/backend/utils/cache/relcache.c | 10 ---------- src/include/utils/relcache.h | 1 - src/test/regress/expected/publication.out | 7 ++++++- src/test/regress/sql/publication.sql | 5 ++++- 5 files changed, 17 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-18 05:34 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-18 05:34 pgsql: Don't quote the relation name twice in EXCEPT clause errors. Amit Kapila <akapila@postgresql.org> 2026-09-18 05:34 pgsql: Don't quote the relation name twice in EXCEPT clause errors. Amit Kapila <akapila@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox