agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't quote the relation name twice in EXCEPT clause errors.
Date: Fri, 18 Sep 2026 05:34:19 +0000
Message-ID: <E1x7REp-00000000DcX-2rlh@gemulon.postgresql.org> (raw)
Don't quote the relation name twice in EXCEPT clause errors.
Commit a49b9cfd72 began reporting the EXCEPT clause relation with a
schema-qualified name that quotes identifiers when needed, inside a
message that already puts the name in quotes. So a schema or relation name
that needs quoting came out quoted twice.
Fix by building the qualified name as "%s.%s" without identifier quoting,
so it renders like the qualified names in other backend error messages.
The message text, and so its translations, is unchanged.
RelationGetQualifiedRelationName() has no callers left, so remove it.
Author: Manuel Reyes Bravo <manuelreyesbravo@gmail.com>
Reviewed-by: shveta malik <shveta.malik@gmail.com>
Reviewed-by: Vignesh C <vignesh21@gmail.com>
Reviewed-by: Peter Smith <smithpb2250@gmail.com>
Reviewed-by: Zhijie Hou <houzj.fnst@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwHfESBexa7fq99EvFCf31av=O9h9udnw22ymxmm6LMZzw@mail.gmail.com
Backpatch-through: 19, where it was introduced
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/644e00f7f2dc992ed368eac37693be5458b869d9
Modified Files
--------------
src/backend/catalog/pg_publication.c | 8 +++++++-
src/backend/utils/cache/relcache.c | 10 ----------
src/include/utils/relcache.h | 1 -
src/test/regress/expected/publication.out | 7 ++++++-
src/test/regress/sql/publication.sql | 5 ++++-
5 files changed, 17 insertions(+), 14 deletions(-)
view thread (2+ messages)
Message-ID: <E1x7REp-00000000DcX-2rlh@gemulon.postgresql.org>
Permalink: ../E1x7REp-00000000DcX-2rlh@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x7REp-00000000DcX-2rlh@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't quote the relation name twice in EXCEPT clause errors.
In-Reply-To: <E1x7REp-00000000DcX-2rlh@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox