agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: postgres_fdw: Fix oversights in fetch_attstats(). 2+ messages / 1 participants [nested] [flat]
* pgsql: postgres_fdw: Fix oversights in fetch_attstats(). @ 2026-09-18 08:47 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Etsuro Fujita @ 2026-09-18 08:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix oversights in fetch_attstats(). The query to get attribute statistics from a remote server applied the "C" collation to a column of type name without checking the server's version. Since the name type was made collatable in Postgres 12, this could break attribute statistics import if the server was older. Fix by casting the column value to text before collating it if the server is older. Also, fix a typo in the if-test in the same function. Oversights in commit 28972b6fc; the former was reported by Fujii Masao. Reported-by: Fujii Masao <masao.fujii@gmail.com> Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Corey Huinker <corey.huinker@gmail.com> Discussion: https://postgr.es/m/CAHGQGwGvA_3q7Wg7GXQkuugGZj3%3DkxDRjDsKgVvK1uwAxHTopQ%40mail.gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/bea01b825c077e73b009be0a6f000ed643490ae9 Modified Files -------------- contrib/postgres_fdw/postgres_fdw.c | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: postgres_fdw: Fix oversights in fetch_attstats(). @ 2026-09-18 08:47 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Etsuro Fujita @ 2026-09-18 08:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix oversights in fetch_attstats(). The query to get attribute statistics from a remote server applied the "C" collation to a column of type name without checking the server's version. Since the name type was made collatable in Postgres 12, this could break attribute statistics import if the server was older. Fix by casting the column value to text before collating it if the server is older. Also, fix a typo in the if-test in the same function. Oversights in commit 28972b6fc; the former was reported by Fujii Masao. Reported-by: Fujii Masao <masao.fujii@gmail.com> Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Corey Huinker <corey.huinker@gmail.com> Discussion: https://postgr.es/m/CAHGQGwGvA_3q7Wg7GXQkuugGZj3%3DkxDRjDsKgVvK1uwAxHTopQ%40mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8dde0b260c27fffba999d5424143b0f1f7b3d292 Modified Files -------------- contrib/postgres_fdw/postgres_fdw.c | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-18 08:47 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-18 08:47 pgsql: postgres_fdw: Fix oversights in fetch_attstats(). Etsuro Fujita <efujita@postgresql.org> 2026-09-18 08:47 pgsql: postgres_fdw: Fix oversights in fetch_attstats(). Etsuro Fujita <efujita@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox