agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Etsuro Fujita <efujita@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postgres_fdw: Fix oversights in fetch_attstats().
Date: Fri, 18 Sep 2026 08:47:34 +0000
Message-ID: <E1x7UFq-00000000EsD-40LW@gemulon.postgresql.org> (raw)
postgres_fdw: Fix oversights in fetch_attstats().
The query to get attribute statistics from a remote server applied the
"C" collation to a column of type name without checking the server's
version. Since the name type was made collatable in Postgres 12, this
could break attribute statistics import if the server was older. Fix by
casting the column value to text before collating it if the server is
older.
Also, fix a typo in the if-test in the same function.
Oversights in commit 28972b6fc; the former was reported by Fujii Masao.
Reported-by: Fujii Masao <masao.fujii@gmail.com>
Author: Etsuro Fujita <etsuro.fujita@gmail.com>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwGvA_3q7Wg7GXQkuugGZj3%3DkxDRjDsKgVvK1uwAxHTopQ%40mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bea01b825c077e73b009be0a6f000ed643490ae9
Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 29 ++++++++++++++++++++++-------
1 file changed, 22 insertions(+), 7 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1x7UFq-00000000EsD-40LW@gemulon.postgresql.org>
Permalink: ../E1x7UFq-00000000EsD-40LW@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x7UFq-00000000EsD-40LW@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: efujita@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: postgres_fdw: Fix oversights in fetch_attstats().
In-Reply-To: <E1x7UFq-00000000EsD-40LW@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox