agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix RI fast-path permission checks
Date: Sat, 19 Sep 2026 02:05:59 +0000
Message-ID: <E1x7kSl-00000000Kzz-3T27@gemulon.postgresql.org> (raw)
Fix RI fast-path permission checks
The fast path required table-level SELECT on the referenced table,
rejecting checks that the SPI path allows with column-level grants.
It also omitted the UPDATE privilege required by FOR KEY SHARE.
When table privileges do not suffice, use ExecCheckOneRelPerms() with
the referenced key columns as selectedCols and an empty updatedCols.
This accepts SELECT on all referenced columns and UPDATE on any column,
the same privileges the executor would require for the SELECT ... FOR
KEY SHARE the SPI path runs. Keep the table-privilege check as a
shortcut that avoids constructing a column bitmap in the usual case.
Add missing regression test coverage for the fixed cases.
Reported-by: Nikolay Samokhvalov <nik@postgres.ai>
Author: Nikolay Samokhvalov <nik@postgres.ai>
Co-authored-by: Amit Langote <amitlangote09@gmail.com>
Discussion: https://www.postgr.es/m/CAM527d9BgPjeOOYmbCBTd57R145qHCk-dzw9qNq%2BnOrDq1j__A%40mail.gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2fc654e1133e987319d54661f0f7ee2babb33488
Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 45 +++++++++++++++++------
src/test/regress/expected/foreign_key.out | 55 ++++++++++++++++++++++++++--
src/test/regress/sql/foreign_key.sql | 59 +++++++++++++++++++++++++++++--
3 files changed, 145 insertions(+), 14 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1x7kSl-00000000Kzz-3T27@gemulon.postgresql.org>
Permalink: ../E1x7kSl-00000000Kzz-3T27@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x7kSl-00000000Kzz-3T27@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix RI fast-path permission checks
In-Reply-To: <E1x7kSl-00000000Kzz-3T27@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox